ALL-CONT0004 · examples

These examples come directly from ALL-CONT0004. Read their source.

Bad

def settle(orders):
    for order in orders:
        if order.is_open:
            for item in order.items:
                if item.is_taxed:
                    charge(item)

Good

def settle(orders):
    for order in orders:
        if order.is_open:
            settle_items(order)

def settle_items(order):
    for item in order.items:
        if item.is_taxed:
            charge(item)