ALL-DUPL0005 · examples

These examples come directly from ALL-DUPL0005. Read their source.

Bad

default_topic = "audit-events"
retry_topic = "audit-events"
known = ("audit-events", "audit-events")
if record.topic == "audit-events":
    ...

Good

AUDIT_TOPIC = "audit-events"

default_topic = AUDIT_TOPIC
retry_topic = AUDIT_TOPIC
known = (AUDIT_TOPIC, AUDIT_TOPIC)
if record.topic == AUDIT_TOPIC:
    ...

A module stating `audit-events` four times of its own returns `1`. The same module stating it
three times returns `0`, and so does one repeating `id` ten times, because that token is below
the length floor. A module calling `frame.select("start_line")` in ten places returns `0`,
because the column name belongs to the frame rather than to the module.